feat: deprecate unnecessary opcodes #1563
Merged
+301
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
4 times, most recently
from
6b863ed to
746d648
Compare
|
Bencher Report| Branch | feat/remove-unused-opcodes |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.69 m(-1.68%)Baseline: 1.71 m | 1.54 m (91.53%) | 2.06 m (81.94%) |
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
7 times, most recently
from
d094ac2 to
10a4030
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1563 +/- ##
==========================================
- Coverage 86.24% 85.70% -0.55%
==========================================
Files 439 439
Lines 33724 33769 +45
Branches 5280 5279 -1
==========================================
- Hits 29086 28942 -144
- Misses 3623 3812 +189
Partials 1015 1015 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
glevco
force-pushed
the
refactor/consensus-features
branch
4 times, most recently
from
e4b1772 to
9fe977f
Compare
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
4 times, most recently
from
fba3149 to
ca88671
Compare
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
from
ca88671 to
c7ccccb
Compare
msbrogli
previously approved these changes
Jan 23, 2026
github-project-automation
bot
moved this from In Progress (Done)
to In Review (WIP)
in Hathor Network
glevco
force-pushed
the
refactor/consensus-features
branch
from
9fe977f to
73d3e56
Compare
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
from
c7ccccb to
846a2b7
Compare
github-project-automation
bot
moved this from In Review (WIP)
to Waiting to be deployed
in Hathor Network
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
from
0dfe92e to
3e32c9b
Compare
jansegre
approved these changes
Jan 26, 2026
jansegre
previously approved these changes
Jan 27, 2026
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
3 times, most recently
from
45156d5 to
eec2ff0
Compare
jansegre
approved these changes
Jan 27, 2026
msbrogli
approved these changes
Jan 27, 2026
glevco
force-pushed
the
feat/remove-unused-opcodes
branch
from
eec2ff0 to
d541770
Compare
msbrogli
force-pushed
the
feat/remove-unused-opcodes
branch
from
d541770 to
a5c6ab2
Compare
github-project-automation
bot
moved this from In Review (Done)
to Waiting to be deployed
in Hathor Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are unused opcodes that were once created for a cancelled implementation. This PR defines a Feature Activation to remove them.
Acceptance Criteria
.venvto ignore ofyamllint. It was complaining in my local env sometimes.Feature.OPCODES_V2and respective settingHathorSettings.ENABLE_OPCODES_V2, defaulting to disabled.OpcodeVersion, removing deprecated opcodes onV2, which is configured via feature activation.SignedData.checksigis set to useV2directly, without feature activation. This is allowed since there are no blueprints withSignedDataon mainnet.V2directly, so we reject txs with deprecated opcodes in the mempool.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged